wu-sheng commented on code in PR #136:
URL: https://github.com/apache/skywalking-java/pull/136#discussion_r841440944
##########
apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/common/AtomicRangeIntegerTest.java:
##########
@@ -49,19 +49,22 @@ public void testGetAndIncrement() {
@Test
@Benchmark
public void testGetAndIncrementV1Performance() {
- ATOMIC_V1.getAndIncrement();
+ final int result = ATOMIC_V1.getAndIncrement();
+ Assert.assertTrue(result >= 0 && result <= 100);
Review Comment:
Why do we need `Assert`? This is benchmark testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
