Hi, the PR has been merged and now we require JDK 11 when developing and running skywalking main repo.
> On Feb 14, 2023, at 14:22, kezhenxu94 <[email protected]> wrote: > > I've filed this PR [1], when we have a conclusion here we can merge that > > [1] https://github.com/apache/skywalking/pull/10390 > >> On Feb 14, 2023, at 11:18, Sheng Wu <[email protected]> wrote: >> >> +1 binding >> >> Anyway, if we don't have objections, we are good to move forward. This >> doesn't break anything :) >> >> Sheng Wu 吴晟 >> Twitter, wusheng1108 >> >> kezhenxu94 <[email protected]> 于2023年2月14日周二 09:52写道： >>> >>> Hi, let's vote on upgrading to Java version 11 for now, >>> users can choose to use Java 17 at runtime if they want, >>> this is not a blocker to upgrade the development to Java 11. >>> >>>> On Feb 13, 2023, at 21:47, Sheng Wu <[email protected]> wrote: >>>> >>>> The reason I am asking about this is that JDK GC perf improvement >>>> usually is relative to how you use memory. >>>> OAP eating memory and have a high load for GC, I am thinking whether >>>> it is meaningful for OAP + JDK17 runtime. >>>> >>>> Sheng Wu 吴晟 >>>> Twitter, wusheng1108 >>>> >>>> kezhenxu94 <[email protected]> 于2023年2月13日周一 21:44写道： >>>>> >>>>> In terms of JDK performance improvements, I think it's usually >>>>> about GC and the Java virtual machine itself, which means most (if not >>>>> all) Java applications >>>>> should benefit from, I believe OAP is not an exception 😂. >>>>> >>>>>>> On Feb 13, 2023, at 21:38, Sheng Wu <[email protected]> wrote: >>>>>>> >>>>>>> About more aggressive, do we have any tests or do we have anyone to >>>>>>> run some perf. tests on JDK 17 as a comparison? >>>>>>> >>>>>>> Sheng Wu 吴晟 >>>>>>> Twitter, wusheng1108 >>>>>>> >>>>>>> 陆家靖 <[email protected]> 于2023年2月13日周一 21:35写道： >>>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>> Shall we move directly to JDK17 as Spring Boot 3 has done? >>>>>>>> >>>>>>>> The overall performance in JDK17 is much better than the previous >>>>>>>> versions. >>>>>>>> And ZGC is production ready since JDK15. I suppose OAP would benefit >>>>>>>> from this. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Jiajing >>>>>>>> >>>>>>>> Sheng Wu <[email protected]> 于2023年2月13日周一 21:27写道： >>>>>>>>> >>>>>>>>> Agree. With a server, we could upgrade to a newer version of JDK. >>>>>>>>> Let's see whether we could commit JDK 11 and JDK 17 compiling support, >>>>>>>>> and run in JDK 11 officially. >>>>>>>>> >>>>>>>>> Sheng Wu 吴晟 >>>>>>>>> Twitter, wusheng1108 >>>>>>>>> >>>>>>>>> kezhenxu94 <[email protected]> 于2023年2月13日周一 21:14写道： >>>>>>>>>> >>>>>>>>>> Hi all, recently I've merged a pull request[1] that migrates our >>>>>>>>>> tests in main repo >>>>>>>>>> from junit 4 to junit 5, I've also verified the tests passed in Java >>>>>>>>>> 11 and above, >>>>>>>>>> now, I'm proposing to upgrade the minimum required Java version, >>>>>>>>>> including >>>>>>>>>> development environment (JDK version), and runtime environment (JRE >>>>>>>>>> version) to Java 11. >>>>>>>>>> >>>>>>>>>> Java 8 is a popular version, there are a lot of projects still using >>>>>>>>>> it, >>>>>>>>>> but fact is fact, Java 8 is really old and there are lots of >>>>>>>>>> fascinating features >>>>>>>>>> in Java 11 that we will benefit in our development experience, there >>>>>>>>>> are also >>>>>>>>>> some performance improvements that we will benefit at runtime, so I >>>>>>>>>> would be >>>>>>>>>> really excited if we could bump up the Java version to Java 11. >>>>>>>>>> >>>>>>>>>> What do you think? If you have any concern, please reply here and we >>>>>>>>>> can discuss >>>>>>>>>> more before we make a decision, if you are excited too to upgrade >>>>>>>>>> the Java version, >>>>>>>>>> please vote here! >>>>>>>>>> >>>>>>>>>> [1] https://github.com/apache/skywalking/pull/10382 >>>>>> >>> >
