+1 binding

1. .sha512 files are checked.
2. GPG signatures are signed by Han Liu <[email protected]>.
3. LICENSE and NOTICE exist.
4. make build passed.
5. Tag correct.

—————————
Kai Wan
GitHub @wankai123

Sheng Wu <[email protected]> 于2023年6月1日周四 09:57写道:
>
> +1 binding
>
> 1. asc checked
> 2. sha exists
> 3. compiling passed from source
> 4. version correct
> 5. tag correct
> 6. LICENSE and NOTICE are there.
>
> One nit, your notice doesn't update to the latest year, it is 2022
> > Copyright 2017-2022 The Apache Software Foundation
>
> Please fix in the next release.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
> han liu <[email protected]> 于2023年5月31日周三 22:14写道:
> >
> > Hi the SkyWalking Community:
> > This is a call for vote to release Apache SkyWalking Go version 0.1.0.
> >
> > Release notes:
> >
> >  * https://github.com/apache/skywalking-go/blob/v0.1.0/CHANGES.md
> >
> > Release Candidate:
> >
> >  * https://dist.apache.org/repos/dist/dev/skywalking/go/0.1.0
> >  * sha512 checksums
> >    - 
> > dd6cac4f4c13683f251b33218697ad1a3cfbca222cffa63c0ded34cb0cf4c81011c1b1ad10d7d313cee682ed64e7a4c52a57266dea8ae08a5d477abed46e1dbf
> >  apache-skywalking-go-0.1.0-src.tgz
> >    - 
> > 72cd3cc646ed23a539694c791dd219f91be7e850ac449c71db23a70489b89368073ae34606df1e5840d4f33c21e365a551faf796bf1bc7703fa3e3620b13e36b
> >  apache-skywalking-go-0.1.0-bin.tgz
> >
> > Release Tag :
> >
> >  * (Git Tag) v0.1.0
> >
> > Release Commit Hash :
> >
> >  * 
> > https://github.com/apache/skywalking-go/tree/0c54f7fe6e622fb01e5f39fe164d7ed582843cac
> >
> > Keys to verify the Release Candidate :
> >
> >  * https://dist.apache.org/repos/dist/release/skywalking/KEYS
> >
> > Guide to build the release from source :
> >
> >  * 
> > https://github.com/apache/skywalking-go/blob/v0.1.0/docs/en/development-and-contribution/how-to-release.md
> >
> > Voting will start now and will remain open for at least 72 hours, all
> > PMC members are required to give their votes.
> >
> > [ ] +1 Release this package.
> > [ ] +0 No opinion.
> > [ ] -1 Do not release this package because....
> >
> > Thanks.
> >
> > [1] 
> > https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-release.md#vote-check

Reply via email to