[ 
https://issues.apache.org/jira/browse/SLIDER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157584#comment-14157584
 ] 

Ted Yu commented on SLIDER-374:
-------------------------------

Thanks for the patch.

Please enclose the close() calls in finally block.

Rename the patch so that it ends with .txt or .patch - currently the patch 
downloads as aslider374-patch.html

> Potential resource leak in accumulo/CertUtil.java due to unclosed streams
> -------------------------------------------------------------------------
>
>                 Key: SLIDER-374
>                 URL: https://issues.apache.org/jira/browse/SLIDER-374
>             Project: Slider
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: thomas liu
>            Priority: Minor
>         Attachments: aslider374-patch
>
>
> In 
> app-packages/accumulo/src/test/java/org/apache/slider/funtest/accumulo/CertUtil.java
>  :
> {code}
>     signerKeystore.load(new FileInputStream(rootKeystorePath), 
> signerPasswordArray);
> {code}
> The load() call doesn't close the passed in stream.
> The caller should close it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to