Note that adding a new required protobuf field effectively breaks all existing clients, as they don't have the field.
We should be using "optional" -as you did in the fix, unless breaking those clients is what we really want. > On 2 Apr 2015, at 04:27, Gour Saha (JIRA) <[email protected]> wrote: > > > [ > https://issues.apache.org/jira/browse/SLIDER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Gour Saha resolved SLIDER-837. > ------------------------------ > Resolution: Fixed > >> Test failures - TestStandaloneYarnRegistryAM and TestStandaloneAgentAM >> ---------------------------------------------------------------------- >> >> Key: SLIDER-837 >> URL: https://issues.apache.org/jira/browse/SLIDER-837 >> Project: Slider >> Issue Type: Bug >> Components: test >> Affects Versions: Slider 0.80 >> Reporter: Gour Saha >> Assignee: Gour Saha >> Fix For: Slider 0.80 >> >> >> *org.apache.slider.agent.standalone.TestStandaloneAgentAM.testStandaloneAgentAM* >> Failing for the past 1 build (Since Failed#609 ) >> Took 32 sec. >> Error Message >> {noformat} >> java.lang.NullPointerException >> at >> org.apache.slider.api.proto.Messages$RoleInstanceState$Builder.setAppVersion(Messages.java:2471) >> at >> org.apache.slider.server.appmaster.state.RoleInstance.toProtobuf(RoleInstance.java:208) >> at >> org.apache.slider.server.appmaster.rpc.SliderIPCService.getClusterNodes(SliderIPCService.java:282) >> at >> org.apache.slider.server.appmaster.rpc.SliderClusterProtocolPBImpl.getClusterNodes(SliderClusterProtocolPBImpl.java:125) >> at >> org.apache.slider.api.proto.SliderClusterAPI$SliderClusterProtocolPB$2.callBlockingMethod(SliderClusterAPI.java:508) >> at >> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:619) >> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962) >> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2039) >> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2035) >> at java.security.AccessController.doPrivileged(Native Method) >> at javax.security.auth.Subject.doAs(Subject.java:415) >> at >> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1628) >> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2033) >> Stacktrace
