[ https://issues.apache.org/jira/browse/SLIDER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524437#comment-14524437 ]
Gour Saha commented on SLIDER-847: ---------------------------------- [~thomas_liu] this patch looks ok to me. Just make sure all the unit and fun-tests ran successfully in your vm. Since {{appDefinitionPersister.processSuppliedDefinitions}} was moved around we want to make sure it didn't cause any regression. Once you confirm I will check in this test patch. > Add unit and functional test cases for App packages > --------------------------------------------------- > > Key: SLIDER-847 > URL: https://issues.apache.org/jira/browse/SLIDER-847 > Project: Slider > Issue Type: Sub-task > Components: app-package, client > Reporter: thomas liu > Assignee: thomas liu > Fix For: Slider 0.80 > > Attachments: JIRA-847-001.patch > > > Scenarios: > Invalid inputs: > * --addon option missing package name or zip file path > * --addon zip file path doesn't exist > * --addon package definition file is not a zipped file > * --addon invalid package name > * create application before master package installed > * package zipped file doesn't contain metainfo.json/xml > * package zipped file metainfo.json/xml isn't valid > * python scripts in metainfo.json/xml don't exist -- This message was sent by Atlassian JIRA (v6.3.4#6332)