[
https://issues.apache.org/jira/browse/SLIDER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003524#comment-15003524
]
Gour Saha commented on SLIDER-930:
----------------------------------
Few comments -
h6. AbstractLauncher.java
{quote}
log.info("Setting " +
ResourceKeys.YARN_RESOURCEMANAGER_AM_RETRY_COUNT_WINDOW_MS +
" to " + amRetryCountWindow);
{quote}
Can you use string formatter {} instead of doing string concats? E.g.
{code}
log.debug("{} resources: ", localResources.size());
{code}
h6. ResourceKeys.java
{quote}
String YARN_RESOURCEMANAGER_AM_RETRY_COUNT_WINDOW_MS =
"yarn.resourcemanager.am.retry-count-window-ms";
{quote}
Can you break this into 2 lines?
h6. TestAppMasterLauncherWithAmReset.java
Please add the Apache license header.
> Incorporate Yarn feature of resetting AM failure count into Slider AM
> ---------------------------------------------------------------------
>
> Key: SLIDER-930
> URL: https://issues.apache.org/jira/browse/SLIDER-930
> Project: Slider
> Issue Type: Bug
> Components: appmaster
> Affects Versions: Slider 0.80
> Reporter: Gour Saha
> Assignee: Sherry Guo
> Fix For: Slider 0.90
>
> Attachments: SLIDER-930-001.patch
>
>
> YARN-611 provides this feature. Currently Slider apps are bound by the number
> set for yarn.resourcemanager.am.max-retries in the cluster. By default this
> value is set to 2, which is very low for long running services.
> Slider AM should use the feature provided in YARN-611 and set an interval
> after which the failure count will be reset to 0.
> I believe the API to call on ApplicationSubmissionContext is
> attemptFailuresValidityInterval. To start with Slider can set it to 5 mins
> which should be a reasonable default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
