This struck me as a little odd. All of the Python files are contained in src/{main,test} and they're even ignored by Git.

I'll have to poke into this. It seems to me that we should not be running any Python code from src/ (only from target) and RAT should catch any *.pyc files we have in the source tree at build time. This shouldn't be a last-minute cleanup when we're making a release.

-------- Original Message --------
Subject: [2/2] incubator-slider git commit: SLIDER-1014: rm *.pyc from all source dirs
Date: Sun, 27 Dec 2015 22:11:23 -0000
From: [email protected]
Reply-To: [email protected]
To: [email protected]

SLIDER-1014: rm *.pyc from all source dirs


Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/f939d903
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/f939d903
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/f939d903

Branch: refs/heads/branches/branch-0.9
Commit: f939d90313d6a6c399fddc42ad3e82a3ab1b56aa
Parents: a89586b
Author: Steve Loughran <[email protected]>
Authored: Sun Dec 27 22:11:06 2015 +0000
Committer: Steve Loughran <[email protected]>
Committed: Sun Dec 27 22:11:06 2015 +0000

----------------------------------------------------------------------
 bin/release.xml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/f939d903/bin/release.xml
----------------------------------------------------------------------
diff --git a/bin/release.xml b/bin/release.xml
index 77997e6..f799593 100644
--- a/bin/release.xml
+++ b/bin/release.xml
@@ -125,7 +125,7 @@

       svn publishing
       --------------
-      svn.publish.dir:        ${slider.publish.dir}
+      svn.publish.dir:        ${svn.publish.dir}
       svn.commit.message:     ${svn.commit.message}
       svn

@@ -284,6 +284,8 @@

   <target name="clean" depends="init">
     <mvn command="clean -Pall-modules" />
+    <!-- rm all .pyc files -->
+    <delete dir="." includes="**/*.pyc" />
   </target>

   <target name="install" depends="init, rat">
@@ -534,7 +536,6 @@ with the subject and body derived from ${slider.vote.file}
     description="generate the vote text -after validating its links"
     />

-
   <target name="release-no-commit"
depends="git-check-unmodified, rat, deploy, tarball-no-package, copy-to-svn">
     <echo>Artifacts staged on Nexus repository</echo>

Reply via email to