Hi Jon,

Did you get a chance to try to reproduce the issue with component
containing a dash ?

Thanks,

Manoj

On Thu, Jan 14, 2016 at 10:42 AM, Gour Saha <gs...@hortonworks.com> wrote:

> Ok great.
>
> Steve,
> This is interesting. I don’t see anywhere we validate the component name
> against a dash. Am I missing something in the code :(
>
> -Gour
>
> On 1/14/16, 10:33 AM, "Manoj Samel" <manojsamelt...@gmail.com> wrote:
>
> >@Gour - yes, it does work when component name does not have a dash. It
> >also
> >works when component name has underscore(s)
> >
> >Thanks,
> >
> >Manoj
> >
> >On Thu, Jan 14, 2016 at 10:25 AM, Gour Saha <gs...@hortonworks.com>
> wrote:
> >
> >> Ah, my bad. Nevertheless can I assume the app works fine when you do not
> >> include dash in component name?
> >>
> >> -Gour
> >>
> >> On 1/14/16, 9:42 AM, "Manoj Samel" <manojsamelt...@gmail.com> wrote:
> >>
> >> >Hi Gour,
> >> >
> >> >1. The issue is with component name. The code you pointed is for
> >>cluster
> >> >name
> >> >2. As mentioned above, the component name does not seem to allow dash
> >>"-",
> >> >it does allow underscore.
> >> >
> >> >Thanks,
> >> >
> >> >Manoj
> >> >
> >> >On Thu, Jan 14, 2016 at 9:24 AM, Gour Saha <gs...@hortonworks.com>
> >>wrote:
> >> >
> >> >> The current acceptable name pattern is [a-z][a-z0-9_-]*
> >> >>(SliderUtils.java
> >> >> - clusternamePattern). It includes the dash (-).
> >> >>
> >> >> While Jon experiments with your package, just wondering your app
> >>works
> >> >> fine when you get rid of the dash, right?
> >> >>
> >> >> -Gour
> >> >>
> >> >> On 1/14/16, 8:35 AM, "Jon Maron" <jma...@hortonworks.com> wrote:
> >> >>
> >> >> >Sorry - got pulled off on some other tasks.  I¹ll try to take a look
> >> >>over
> >> >> >the next day or so.
> >> >> >
> >> >> >> On Jan 14, 2016, at 11:31 AM, Manoj Samel
> >><manojsamelt...@gmail.com>
> >> >> >>wrote:
> >> >> >>
> >> >> >> Hi,
> >> >> >>
> >> >> >> Any update on this ? Did you get a chance to try the memcache with
> >> >>the
> >> >> >> component name I used above ?
> >> >> >>
> >> >> >> Thanks,
> >> >> >>
> >> >> >> Manoj
> >> >> >>
> >> >> >> On Tue, Jan 12, 2016 at 4:37 PM, Steve Loughran
> >> >><ste...@hortonworks.com
> >> >> >
> >> >> >> wrote:
> >> >> >>
> >> >> >>>
> >> >> >>>> On 12 Jan 2016, at 12:14, Jon Maron <jma...@hortonworks.com>
> >> wrote:
> >> >> >>>>
> >> >> >>>> OK.  So was there a Œ-Œ or some other character in your
> >>component
> >> >> >>>>name?
> >> >> >>> A Œ-Œ should work.  The component names are currently expected to
> >> >> >>>follow a
> >> >> >>> naming convention that allows for DNS compatible names, and
> >>dashes
> >> >>are
> >> >> >>> included in that character set.  The fact that the endpoint did
> >>not
> >> >> >>>appear
> >> >> >>> may be related to some other issue.  The AM logs may help here as
> >> >>well.
> >> >> >>>
> >> >> >>>
> >> >> >>> We should be checking component names early on, because it would
> >> >>really
> >> >> >>> break bits of the REST API too.
> >> >> >
> >> >>
> >> >>
> >>
> >>
>
>

Reply via email to