Hi,

Thomas brought up the question that he found it unexpected that I had squashed the pull request instead of retaining the original commits. (Read up on SLIDER-977 to avoid me putting incorrect words in his mouth)

I had done this because it was 44 commits originally spanning a time frame of over one year.

I don't think we've had a discuss on our guidelines for contributor attribution.

Should we have direct commit-by-commit attribution for changes or should we try to target squashed commits (one commit per JIRA issue)?

What about the Git "author": should it be one of the committers, the contributor, the contributor with the committer signed-off'ing, or the committer with a mention of the contributor in the commit message?

Thoughts?

- Josh

Reply via email to