[ 
https://issues.apache.org/jira/browse/SLIDER-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308218#comment-15308218
 ] 

Gour Saha commented on SLIDER-1134:
-----------------------------------

I am trying to understand now why _*getCompOptionMap()*_ is always merged into 
_*buildAppOptionsConfTree()*_ and _*buildResourceOptionsConfTree()*_. Seems 
like that is the source of the problem. [~billie.rinaldi], 
[~ste...@apache.org], any idea why? 

{code}
  public ConfTree buildAppOptionsConfTree() throws
      BadCommandArgumentsException {
    return buildConfTree(getOptionsMap());
  }

  public ConfTree buildResourceOptionsConfTree() throws
      BadCommandArgumentsException {
    return buildConfTree(getResourceOptionsMap());
  }

  protected ConfTree buildConfTree(Map<String, String> optionsMap) throws
      BadCommandArgumentsException {
    ConfTree confTree = new ConfTree();
    ConfTreeOperations ops = new ConfTreeOperations(confTree);
    confTree.global.putAll(optionsMap);
    Map<String, Map<String, String>> roleOptionMap = getCompOptionMap();
    for (Map.Entry<String, Map<String, String>> entry : 
roleOptionMap.entrySet()) {
      String key = entry.getKey();
      Map<String, String> value = entry.getValue();
      ops.getOrAddComponent(key).putAll(value);
    }
    return confTree;
  }
{code}

> App config key-value pairs specified on the command line seeps into resources 
> definition
> ----------------------------------------------------------------------------------------
>
>                 Key: SLIDER-1134
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1134
>             Project: Slider
>          Issue Type: Bug
>          Components: client
>    Affects Versions: Slider 0.90.2
>            Reporter: Gour Saha
>            Assignee: Gour Saha
>
> When app config key-value pairs specified on the command line using 
> _*--compopt*_, they seep into resources definition and causes app fail to 
> start. Only yarn.* keys are allowed in resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to