[
https://issues.apache.org/jira/browse/SLIDER-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366908#comment-15366908
]
Gour Saha commented on SLIDER-1151:
-----------------------------------
Thanks [~manojsamel]. I committed it just now for you.
One suggestion is to name the patch in a format something in the lines of
<jira_id>_001.patch or <jira_id>.001.patch, e.g. SLIDER-1151.001.patch.
> Don't log Invalid port range values when there are no invalid ports specified
> -----------------------------------------------------------------------------
>
> Key: SLIDER-1151
> URL: https://issues.apache.org/jira/browse/SLIDER-1151
> Project: Slider
> Issue Type: Improvement
> Components: agent
> Affects Versions: Slider 0.80
> Reporter: Manoj Samel
> Priority: Minor
> Attachments: check_empty.patch
>
>
> Slider version 0.80
> CustomServiceOrchestrator.py:494 (get_allowed_port_list()) always logs
> invalid port range log message; even when the "invalid" set is empty.
> logger.warning("Invalid port range values: " + str(invalid))
> This just clutters the log with entries like
> WARNING 2016-07-02 09:13:18,489 CustomServiceOrchestrator.py:494 - Invalid
> port range values: set([])
> The warning should be logged only when the invalid set is non-empty
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
