[
https://issues.apache.org/jira/browse/SLIDER-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380864#comment-15380864
]
Billie Rinaldi commented on SLIDER-1157:
----------------------------------------
+1, looks okay to me.
> Code issues - integer handling issues
> -------------------------------------
>
> Key: SLIDER-1157
> URL: https://issues.apache.org/jira/browse/SLIDER-1157
> Project: Slider
> Issue Type: Bug
> Components: other
> Affects Versions: Slider 0.91
> Reporter: Gour Saha
> Assignee: Gour Saha
> Attachments: SLIDER-1157.01.patch
>
>
> Following 2 issues needs to be addressed -
> h4. slider-core/src/main/java/org/apache/slider/core/conf/MapOperations.java
> {code}
> 325 long totalMinutes = days * 24 * 60 + hours * 24 + minutes;
> {code}
> overflow_before_widen: Potentially overflowing expression hours * 24 with
> type int (32 bits, signed) is evaluated using 32-bit arithmetic, and then
> used in a context that expects an expression of type long (64 bits, signed)
> h4. slider-core/src/main/java/org/apache/slider/client/SliderClient.java
> {code}
> 1709 if (clusterComponentInstances
> 1710 .get(clientComponentInstanceEntry.getKey()) ==
> clientComponentInstanceEntry
> 1711 .getValue()) {
> {code}
> defect: Suspicious comparison of Integer references
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
