[
https://issues.apache.org/jira/browse/SLIDER-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406423#comment-15406423
]
Gour Saha commented on SLIDER-1107:
-----------------------------------
bq. All commands automatically have a --help option inherited from
AbstractActionArgs.
Actually for some commands the --help does not work unless it explicitly calls
actionHelp. If you run it local in your mac say, it does not work for the
resources cmd, and throws BindException for not being able to connect to RM. It
had to be done explicitly for flex, package and list commands.
bq. No, we want the user-provided client root to override the default.
In that case should we reverse the lookup order so that _*config*_ is looked
into first and then only if _*clientRoot*_ is null then _*defaultConfig*_ is
looked up. In the current scenario _*defaultConfig*_ will always be looked up.
bq. It wouldn't be a problem to remove static, if you'd prefer that.
I understand this now, so no need to remove static.
+*slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java*+
{code}
os.flush();
os.close();
{code}
Should we introduce a try-finally block and put these in finally, so that in
case of read/write error it will always be closed.
> Generate app configuration files in AM
> --------------------------------------
>
> Key: SLIDER-1107
> URL: https://issues.apache.org/jira/browse/SLIDER-1107
> Project: Slider
> Issue Type: Bug
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Fix For: Slider 1.0.0
>
>
> Currently, each container generates its own application configuration files.
> Instead, we could do this in the AM and have YARN localize the configuration
> files. Having some basic config generation in the AM may allow us to
> simplify the config generation code in the app packages. Also, it would be
> much better in the case of Docker containers, where we would prefer not to
> have to execute our own code inside the container.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
