[
https://issues.apache.org/jira/browse/SLIDER-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467711#comment-15467711
]
Gour Saha commented on SLIDER-1166:
-----------------------------------
Line 109 was this for me first -
{code}
if (zookeeper == null || !getConnected()) {
{code}
but, then I tested with the below line and killed the ZK tcp connection with
tcpkill/killcx and somehow the connection got reestablished, so I removed the
getConnected check
{code}
if (zookeeper == null) {
{code}
I can bring back the check but it seems unnecessary though.
> Every cluster stop operation creates and holds on to a zk session
> -----------------------------------------------------------------
>
> Key: SLIDER-1166
> URL: https://issues.apache.org/jira/browse/SLIDER-1166
> Project: Slider
> Issue Type: Bug
> Components: client
> Affects Versions: Slider 0.91
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Priority: Critical
> Fix For: Slider 1.0.0
>
> Attachments: SLIDER-1166.1.patch, SLIDER-1166.2.patch
>
>
> We aren't closing the zookeeper client, leaving it to expire and keep the
> session open much longer than is necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
