[
https://issues.apache.org/jira/browse/SLIDER-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902637#comment-15902637
]
Gour Saha commented on SLIDER-1213:
-----------------------------------
[~chengeng] the patch looks ok. One comment, instead of defining LIVE_STATUS
and DEAD_STATUS again in both DockerManager.py and YarnDockerManager.py, can
you reference them from CustomServiceOrchestrator?
> docker manager cannot detect failures of running docker containers
> ------------------------------------------------------------------
>
> Key: SLIDER-1213
> URL: https://issues.apache.org/jira/browse/SLIDER-1213
> Project: Slider
> Issue Type: Bug
> Components: agent
> Affects Versions: Slider 0.91
> Reporter: ouchengeng
> Assignee: ouchengeng
> Fix For: Slider 1.0.0
>
> Attachments: SLIDER-1213.patch
>
>
> For docker apps, DockerManager.py is used to monitor the status of running
> docker containers. However, it fails to detect the failures of running
> containers, etc, if I manually stop a docker container, and agent cannot
> detect it.
> There's a bug in DockerManager.py. When querying status, it should not return
> 0 or 1. Instead, it should return "STARTED" or "INSTALLED", as the same in
> CustomServiceOrchestrator.py, because these are the key words that
> Controller.py uses to determine the status of running apps.
> YarnDockerManager has the same issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
