[ https://issues.apache.org/jira/browse/SLIDER-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099015#comment-16099015 ]
Gour Saha commented on SLIDER-1233: ----------------------------------- [~billie.rinaldi] I am looking through the patch. Quick question: if a container is killed by the RM (say for exceeding memory limits), shouldn't it be counted as a container failure? > Lost nodes should not contribute to container failures > ------------------------------------------------------ > > Key: SLIDER-1233 > URL: https://issues.apache.org/jira/browse/SLIDER-1233 > Project: Slider > Issue Type: Bug > Components: core > Reporter: Billie Rinaldi > Assignee: Billie Rinaldi > Fix For: Slider 1.0.0 > > Attachments: SLIDER-1233.001.patch > > > If a container completes due to an NM being lost, we should not count this > towards container failures that may eventually cause the AM to fail the > application. We are already using a ContainerOutcome of Completed (rather > than Failed) for this type of container exit, so we just need to change the > failure counting in that case. Other failure types associated with Completed > are killed by the AM, killed by the RM, and killed after app completion, none > of which need to contribute to container failures. -- This message was sent by Atlassian JIRA (v6.4.14#64029)