[ 
https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756506#action_12756506
 ] 

Felix Meschberger commented on SLING-1113:
------------------------------------------

How about adding tests with File.separatorChar (as in the patch you proposed)

And in BootstrapInstaller.extractFileName we first do

   path = path.replace(File.separatorChar, '/');

then we can use "path.lastIndexOf('/') later


WDYT ?

> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
>                 Key: SLING-1113
>                 URL: https://issues.apache.org/jira/browse/SLING-1113
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>         Environment: Windows XP SP3
>            Reporter: Mike Müller
>            Assignee: Mike Müller
>            Priority: Trivial
>         Attachments: BootstrapInstallerTest.java.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows 
> system the separator char for a directory is \ and not /. The test does not 
> use File.separatorChar to get the right separator but the implementation in 
> BootstrapInstaller does.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to