[ 
https://issues.apache.org/jira/browse/SLING-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Klimetschek updated SLING-1131:
-----------------------------------------

    Attachment: SLING-1131-second-with-tests.patch

Patch against current svn that fixes the problems Felix noted and adds a unit 
test for JcrResourceBundle. The test should cover all use cases. To be applied 
in contrib/extensions/i18n.

Please note that - since it requires on the patch of SLING-1166 to be applied - 
the pom contains a SNAPSHOT reference to org.apache.sling.commons.testing 
(2.0.5-SNAPSHOT). That would require a release of that bundle to avoid snapshot 
references.

> i18n: do not enforce a flat node hierarchy below mix:language
> -------------------------------------------------------------
>
>                 Key: SLING-1131
>                 URL: https://issues.apache.org/jira/browse/SLING-1131
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: I18n 2.0.2
>            Reporter: Alexander Klimetschek
>            Priority: Minor
>             Fix For: I18n 2.0.2
>
>         Attachments: SLING-1131-second-with-tests.patch, SLING-1131.patch
>
>
> Currently the search for translations enforces a flat hierarchy below the 
> mix:language node (that eg. says 'de' for the translation language) for the 
> sling:Message nodes that hold the single translations. If you have many 
> translations, eg. thousands, the flat hierarchy can get slow in Jackrabbit, 
> so it would be good to support a nested hierarchy as well.
> The change boils down to the query that is done. Currently it looks like this 
> (eg. for fetching all translations for 'de'):
> //element(*,mix:language)[...@jcr:language='de']/*/(@sling:key|@sling:message)
> It should introduce a descendant-or-self step:
> //element(*,mix:language)[...@jcr:language='de']//*/(@sling:key|@sling:message)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to