On Mon, Nov 16, 2009 at 4:50 AM, Bertrand Delacretaz <bdelacre...@apache.org > wrote:
> > As demonstrated in your http://gist.github.com/233240 example. > > Two minor things on that example: > > 1) > <executions> > <execution> > <goals><goal>prepare</goal></goals> <!-- granted, this is a > questionable goal name --> > </execution> > </executions> > > How about "create-app" as the goal name? > "create-app" sounds to me like a one-time process that you'd perform when initiating a project. But it's definitely less bland than prepare :) > 2) > <configuration> > <includeDefaultBundles>true</includeDefaultBundles> <!-- if true, > contents of org.apache.sling.launchpad.bundles get unpacked --> > <defaultBundlesVersion>6-SNAPSHOT</defaultBundlesVersion> <!-- > support LATEST, RELEASE here ? --> > > Wouldn't it be clearer to use > > <default-bundles> > ...reference to a Maven artifact, as usual... > </default-bundles> > I don't think so, because then you have to remember the group and artifact for this assembly. I do think it's a good idea to support additional collections of bundles that are structured similarly to org.apache.sling.launchpad.bundles (and updated the gist to reflect this), but I like the simplicity of being able to include the default bundles with minimal configuration. This is a *Sling *plugin and, as such, can/should be optimized for Sling-orientated use cases. I think the gist fails to fully illustrate this because I was trying to show some additional configuration options at the same time as showing what lines in the launchpad poms it could replace. Here are some smaller examples, keeping in mind default values: 1) Sling Launchpad: <configuration> <defaultBundlesVersion>6-SNAPSHOT</defaultBundlesVersion> </configuration> 2) Sling Launchpad plus some extra bundles: <configuration> <defaultBundlesVersion>6-SNAPSHOT</defaultBundlesVersion> <additionalBundles>...</additionalBundles> </configuration> 3) Sling without Sling (i.e. just launcher) plus some extra bundles: <configuration> <includeDefaultBundles>false</includeDefaultBundles> <additionalBundles>...</additionalBundles> and/or <additionalBundlesAssemblies>...</additionalBundlesAssemblies> </configuration> In #1 and #2, the defaultBundlesVersion is optional as it should default to RELEASE. Justin
