[
https://issues.apache.org/jira/browse/SLING-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785894#action_12785894
]
Felix Meschberger commented on SLING-1219:
------------------------------------------
> in the current implementation, if you just use a path like "/content/a/page",
> it will use a dummy request for the map
Ahh, sorry. Missed that one. This looks like not implemented as intended ....
How about better description and this :
Index:
src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceResolverWebConsolePlugin.java
===================================================================
---
src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceResolverWebConsolePlugin.java
(revision 885411)
+++
src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceResolverWebConsolePlugin.java
(working copy)
@@ -180,7 +180,11 @@
// map or resolve as instructed
Object result;
if ("Map".equals(request.getParameter(ATTR_SUBMIT))) {
- result = resolver.map(helper, helper.getPathInfo());
+ if (helper.getRemoteHost() == null) {
+ result = resolver.map(helper.getPathInfo());
+ } else {
+ result = resolver.map(helper, helper.getPathInfo());
+ }
} else {
result = resolver.resolve(helper, helper.getPathInfo());
}
> Map test in JCR Resource Resolver web console plugin is not reflecting all
> cases
> --------------------------------------------------------------------------------
>
> Key: SLING-1219
> URL: https://issues.apache.org/jira/browse/SLING-1219
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Resource 2.0.6
> Reporter: Alexander Klimetschek
> Priority: Minor
> Attachments: SLING-1219.patch
>
>
> The "Map" test in the web console plugin of the JCR resource resolver is
> actually doing a
> ResourceResolver.map(request, path)
> with the request being something like "http://null", without even noting
> that. This is misleading as one would at least expect that the current server
> is used (ie. how the web console is accessed), eg. http://localhost in most
> cases. This difference will give different results in many cases, eg. if an
> internal redirect based on localhost.80 is configured.
> Also, there is a second map() only accepting a path which behaves different
> in that it will always add the domain prefix if configured.
> For proper testing there should be a way to do all of them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.