[ 
https://issues.apache.org/jira/browse/SLING-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830969#action_12830969
 ] 

Felix Meschberger commented on SLING-1116:
------------------------------------------

Thanks again for providing the patch.

I have taken the liberty to simplify it a bit:
  * replaced classes by direct method calls
  * refactored the login page call using a dedicated, configurable login form 
page instead of using selectors
  * merged some configuration properties
  * aligned the form action to the Servlet API 2.4 specification in SRV.12.5.3.1
  * Placed the token store inside the bundle private data (if the path is 
relative)

I have commited it in Rev. 907677 and cleaned up the dependencies in Rev. 907686

In addition I added documentation of this handler at 
http://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/formauth
(support for the j_verify parameter as documented is not implemented yet)

Please review. Thanks.

> FORM Based Authentication
> -------------------------
>
>                 Key: SLING-1116
>                 URL: https://issues.apache.org/jira/browse/SLING-1116
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Eric Norman
>            Assignee: Felix Meschberger
>         Attachments: org.apache.sling.cookieauth.zip, 
> org.apache.sling.sessionauth.zip, SLING_1116_jackrabbit_server_patch.txt, 
> update2_org.apache.sling.cookieauth.zip, 
> updated_org.apache.sling.cookieauth.zip
>
>
> This is a new bundle that provides an implementation of forms based 
> authentication for sling.
> The login/logout servlets from the org.apache.sling.commons.auth are used.
> The AuthenticationHandler will use http basic auth credentials if they are on 
> the request, otherwise it will use the user/pwd posted from the login form.
> The login form html is generated by a set of scripts
> 1. login.html.esp     - full login page (includes login_body.html.esp for the 
> form markup)
> 2. login_body.html.esp   - just the login form, which may be useful for 
> drawing the login form for an ajax context
> 3. loginError.html.esp   - full login-error page
> 4. loginError_body.html.esp  - just the login-error form, for login error in 
> ajax context
> The above scripts are included as bundle-resources @ 
> /libs/sling/servlet/default
> The bundle also has a couple of test scripts to show some examples of usage:
> 1. loginTest.html.esp  - shows who is logged in and links to login or logout
> 2. loginTest2.html.esp - shows how a script can check permissions and show a 
> login page if the anonymous user doesn't have permission to see the page,
> Some examples of usage are:
> 1. http://host:port/path/to/node.login.html   - show the login page and then 
> goto http://host:port/path/to/node after  authenticated
> 2. http://host:port/path/to/node.login.html?s=.edit.html   - show the login 
> page and then goto http://host:port/path/to/node.edit.html after  
> authenticated
> 3. http://host:port/system/sling/logout  - invalidate the session and switch 
> back to anonymous user

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to