Simon Gaeremynck wrote:
> The ignoreImportProviders property as defined on [1] states that you can
> specify multiple readers you wish to ignore.
> For example:
>
> SLING-INF/content;overwrite=true;ignoreImportProviders:=xml,json
>
>
> AFAICT it only chooses the first one.
> I've traced this down to the ManifestHeader class in o.a.s.commons.osgi.
> It looks like it interprets the comma between xml and json as a seperator of
> Attributes instead of a seperator of Values.
>
Thanks for finding this problem, Simon; I must have been day dreaming
while implementing this......in fact a comma is not allowed in the
attribute value, so the parser behaves correctly. But we can't use this
character for separating the values.
Can you please open a JIRA issue for this?
We just have to use a different character, I think '/' is fine though it
would look ugly...
Regards
Carsten
> The following test in ManifestHeaderTest identifies this issue:
>
>
> public void testMultiple() {
> String header =
> "SLING-INF/content/etc;overwrite=true;ignoreImportProviders=json,xml";
> final ManifestHeader entry = ManifestHeader.parse(header);
> assertEquals("json,xml",
> entry.getEntries()[0].getAttributes()[1].getValue());
> }
>
> Regards,
> Simon
>
> [1]
> http://sling.apache.org/site/content-loading-jcrcontentloader.html#ContentLoading(jcr.contentloader)-Extractors
--
Carsten Ziegeler
cziege...@apache.org
