[
https://issues.apache.org/jira/browse/SLING-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849088#action_12849088
]
Felix Meschberger commented on SLING-1456:
------------------------------------------
Rev. 926955:
Added the Servlet API javax.servlet.include.* attribute names as constants to
the SlingConstants interface in the Sling API.
Added a new constant
ATTR_REQUEST_PATH_INFO = "org.apache.sling.api.include.request_path_info"
to purvey the SlingHttpServletRequest.getRequestPathInfo() of the including
servlet or script.
Removed handling of the ATTR_REQUEST_CONTENT and ATTR_REQUEST_SERVLET request
parameters from the RequestData pushContent and popContent methods. These
methods cannot decide whether a request is being included or forwarded to.
Added complete request attribute handling to the SlingRequestDispatcher.include
method. This includes setting and resetting the ATTR_REQUEST_* and
ATTR_INCLUDE_* request attributes. The SlingRequestDispatcher.forward method
has been extended to ensure these attributes are not set.
> "org.apache.sling.api.include.servlet" request attribute is set as well when
> RequestDispatcher#forward is called which is wrong
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1456
> URL: https://issues.apache.org/jira/browse/SLING-1456
> Project: Sling
> Issue Type: Bug
> Components: Servlets
> Reporter: Philipp Koch
> Assignee: Felix Meschberger
> Priority: Critical
>
> how to reproduce:
> forward a file resource and look at the http conversation. you will encounter
> that the "If-Modified-Since" header is never set because of a !included check
> in the StreamRendererServlet#doGet method. in consequence browser caching is
> not possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
