[ https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879901#action_12879901 ]
Justin Edelson commented on SLING-1560: --------------------------------------- I had to look at the code to remember what happened here. I slightly mispoke. The change I failed to make was to upgrade the version of commons.testing being used. In SLING-1488, I extracted a test helper class from jcr.install (EventHelper) into commons.testing. When I went to delete this class from the jcr.install source and have jcr.install refer to the trunk version of commons.testing, two tests started failing. Those failures, I believe, were resulting from testing under Jackrabbit 2. So the "upgrade" is actually to commons.testing 2.0.5-SNAPSHOT, which also will bring in JR 2 and JCR 2 as (test-scoped) dependencies. I could have sworn I posted something to the mailing list about it when it happened, but perhaps I forgot to. > Improve and clean up code > ------------------------- > > Key: SLING-1560 > URL: https://issues.apache.org/jira/browse/SLING-1560 > Project: Sling > Issue Type: Improvement > Components: Installer > Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0 > Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler > Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0 > > > In order to fix some outstanding bugs and to add new features, a code review > and clean up seems to be a good idea :) > This bug will keep track of all changes to the code that don't add new > features -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.