Hi Federico, I reviewed that code, here are my comments (in addition to the ones from last Monday on this list), open for discussion of course!
1) /david/entry_name_.view should be .html, and david .search should be david.search.html for example. 2) For static text like "<h3>David Mini CMS based on Apache Sling</h3>" in esp scripts, it would be good to use Sling's contrib/extensions/i18n module. Not urgent, and we need to discuss exactly how. 3) Making the editor pluggable using an OSGi service would be a good demo of Sling's power - this mostly means generating the CKEDITOR.replace bit (and associated client-side code) from an OSGi service in edit.esp. Or maybe use a servlet Filter for this. Also for later, for now it's just an idea to keep in mind or note as a JIRA wishlist issue. 4) Moving the css and javascript code in header.esp to separate files would be better IMO from a best practices point of view - also not urgent. 5) The way you're using the load() function to modularize your esp scripts is good. 6) As with the ckeditor code, the jquery code should come from a separate bundle, also later. Your main bundle should contain just the code that is specific to your application. So nothing urgent at this point, just a few things to note (JIRA issues?) I think we could discuss the next priorities here now, based on the goals that we set offlist for the first evaluation on July 14th. Thanks for your work and ciao, -Bertrand
