Hi Bertrand, 2010/8/6 Bertrand Delacretaz <bdelacre...@apache.org>
> Hi Federico, > > Here are the raw comments from my review, I'll discuss the next > steps/priorities in a separate message. > > Test scenario, action items marked with -> > > Start sling launchpad/builder -standalone jar after deleting sling work > folder > > Build and install davidgsoc2010 libraries and core bundles in this order > > Core bundle doesn't start, needs additional bundles: > org.apache.sling.commons.scheduler > org.apache.sling.commons.threads > > core bundle now starts. > > -> suggest a README.txt at the top of the davidgsoc2010 code tree that > describes the installation. > Yes, it will be also described in the documentation. > > Open http://localhost:8080/content/david.home.html > > -> should be david.html, as already mentioned. > Fixed with last revision (65) > > Sometimes saving an entry doesn't work, server says > > Error while processing /content/david/2010/08/07/about_sling > javax.jcr.AccessDeniedException: Access denied > > even though I could save another entry seconds before. > > Deleting entries didn't work either, didn't investigate. > > -> need better client-side error messages to troubleshoot such things > I don't understand why. There is the check to see if you are logged and I never received this error. Can you tell me the exact steps you performed? Which browser are you using? > > Search functions seem to work ok, tested with minimal content only. > > On /content/david.list.html the name of the entry should be a link to > READ, and remove that link. Reading is the standard operation. > > -> change links > Fixed with last revision (65) > > The libraries bundle should be split in two: ckeditor and swfobject > for tags display. Or more than two if it contains other independent > components - the idea is to have one bundle per independent component. > The convention is to use /libs, not /libraries for those types of > things. > > -> split bundle > I can split the libraries into two or more bundles, but I think it isn't useful. It can be useful if there is a mechanism to change these components with others (other layout, other JS framework etc. etc.). But to do that I had to focus more on the project that on Sling. Anyway if you think it's a "must-have" feature (also for a future development) I can separate them. > > The core bundle source code structure is nice and clean now, that's > very cool: it contains just the applications layer of the mini-CMS. > > -Bertrand > -- Federico
