[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896926#action_12896926
 ] 

Carsten Ziegeler commented on SLING-1560:
-----------------------------------------

Changes in revision 983998:

Removed the input stream support for dictionaries from the osgi installer - 
reading configurations is up to the providers like jcr install. By removing 
this we can reduce the complexity of the installer.
Moved logging to a Logger class to avoid passing around the installer context 
just for logging
Moved statistics methods to own interface as this is just used for testing and 
should not be part of the public api
Cleaned up installable resource factory
Changed type of installable resource from enum to String in order to provide 
pluggable installers in the future

> Improve and clean up code
> -------------------------
>
>                 Key: SLING-1560
>                 URL: https://issues.apache.org/jira/browse/SLING-1560
>             Project: Sling
>          Issue Type: Improvement
>          Components: Installer
>    Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0
>
>
> In order to fix some outstanding bugs and to add new features, a code review 
> and clean up seems to be a good idea :)
> This bug will keep track of all changes to the code that don't add new 
> features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to