[ 
https://issues.apache.org/jira/browse/SLING-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897805#action_12897805
 ] 

Felix Meschberger commented on SLING-1647:
------------------------------------------

Moved the USER_IMPERSONATOR constant to the ResourceResolver interface in Rev. 
984813.
Add USER, PASSWORD, and USER_IMPERSONATION constants (moved from 
AuthenticationInfo class) to the ResourceResolverFactory interface in Rev. 
984814.
Adapted the Commons Auth code for the moved constants and removed the constants 
from the AuthenticationInfo class in Rev. 984816
Expose o.a.s.jcr.resource API as fixed version 2.1 (instead of refering to the 
project version which is a moving target) in Rev. 984817
Use new constants in the JcrResourceResolver. Add close check to the clome 
method and reuse the clone method for the getResolverForWorkspace method in 
Rev. 984832
Adapted jcr/resource bundle to new constants and added/adapted unit tests in 
Rev. 984840.

> Cleanup Authentication Info constants and implementation
> --------------------------------------------------------
>
>                 Key: SLING-1647
>                 URL: https://issues.apache.org/jira/browse/SLING-1647
>             Project: Sling
>          Issue Type: Improvement
>          Components: API, Commons, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, Commons Auth 1.0.0, API 2.1.0
>
>
> The constants defined on the AuthenticationInfo class in the Commons Auth 
> bundle should be moved as follows:
>     USER = "user.name"
>             to the ResourceResolverFactory interface
>     PASSWORD = "user.password";
>             to the ResourceResolverFactory interface
>     CREDENTIALS = "user.jcr.credentials";
>             to the JcrResourceResolverFactory interface
> In addition support for checking the type of a credentials property is to be 
> removed from the AuthenticationInfo class.
> Likewise the following constants currently internal to the 
> JcrResourceResolverFactoryImpl class should be moved:
>     AUTH_INFO_WORKSPACE = "internal.user.jcr.workspace";
>             to the JcrResourceResolverFactory interface
>             and change value to user.jcr.workspace (removing the internal 
> prefix)
>     SESSION_ATTR_IMPERSONATOR = "impersonator";
>             to the ResourceResolverFactory interface
> Finally the following constant from the ResourceResolverFactory interface 
> should be changed:
>     SUDO_USER_ID = "sudo.user.id";
>             change the value to user.impersonation
> At the end use constants should be ensured, mostly in the 
> JcrResourceResolverFactoryImpl and JcrResourceResolver classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to