[ https://issues.apache.org/jira/browse/SLING-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olaf Otto updated SLING-1701: ----------------------------- Attachment: VelocityTemplatesScriptEngine.java Refactored version of rev. 989119 of https://svn.apache.org/repos/asf/sling/trunk/contrib/scripting/velocity/src/main/java/org/apache/sling/scripting/velocity/VelocityTemplatesScriptEngine.java > contrib/scripting/velocity VelocityTemplatesScriptEngine has multiple issues > ---------------------------------------------------------------------------- > > Key: SLING-1701 > URL: https://issues.apache.org/jira/browse/SLING-1701 > Project: Sling > Issue Type: Improvement > Components: Scripting > Environment: Felix 1.4, Sling 2.0.7, Apache Velocity 1.6.2 > Reporter: Olaf Otto > Priority: Critical > Attachments: VelocityTemplatesScriptEngine.java > > Original Estimate: 1h > Remaining Estimate: 1h > > Affects: Rev. 989119 of > https://svn.apache.org/repos/asf/sling/trunk/contrib/scripting/velocity > (2.0.0-SNAPSHOT) > The VelocityTemplatesScriptEngine has several issues, such as bad exception > handling (catching Throwable instead of Exception), potential NPE's and bad > naming, discarding of exception stacktrace and misleading error messages, > missing Javadoc. Attached is a refactored version of the class. Note that > there are still some opened questions marked with //TODO. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.