Hi, Hmm, was under the impression that we didn't reach consensus.
Anyway, I don't like static fields for stuff, which is used by instances. This sounds incorrect and smells like premature optimization ... Alas, I won't fight now ;-) Regards Felix On 30.08.2010 08:34, Carsten Ziegeler wrote: > Felix Meschberger wrote >> Hi, >> >> On 23.08.2010 17:50, cziege...@apache.org wrote: >>> Author: cziegeler >>> Date: Mon Aug 23 15:50:51 2010 >>> New Revision: 988161 >>> >>> URL: http://svn.apache.org/viewvc?rev=988161&view=rev >>> Log: >>> Use static loggers for data objects >> >> Is there a particular reason for making the GC work harder ? >> > Yes, otherwise it might get bored and throw some random exception :) > > I think we discussed this a long time ago and agreed that we use static > loggers for data objects where we expect a lot of objects to be created > and garbage collected; we already have this for several of such classes > but we never changed this one. > > So basically the rule was a non static logger for services and > components and static loggers for data objects. Of course we can revisit > this and use non static loggers - but whatever we do, we should be > consistent (or at least try to) :) > > Carsten
