Hi, Am 13.09.2010 16:20, schrieb Justin Edelson: > This is perhaps a minor semantic point, but this parameter really > shouldn't be called "resource" if it contains the servlet context path. > It might be too late to change it now, but perhaps this is worthy of a > comment someplace (although I'm not sure where).
Yes, I agree. In fact, I wanted to change this name earlier on but could not do it for backwards compatibility reasons. It is not really a resource in Sling ResourceProvider terms (actually never really has been) but rather kind of an authentication target path, and thus a resource in REST terms. Of course we could introduce a new name and keep on supporting the old name.... Regards Felix > > Justin > > On 9/13/10 6:13 AM, Felix Meschberger (JIRA) wrote: >> >> [ >> https://issues.apache.org/jira/browse/SLING-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Felix Meschberger resolved SLING-1752. >> -------------------------------------- >> >> Fix Version/s: Form Based Authentication 1.0.2 >> Auth Core 1.0.4 >> Resolution: Fixed >> >> Issue is tha tthe redirect based on the resource request parameter and/or >> attribute has been implemented slightly differently in all kinds of >> locations in the auth modules. >> >> Introducing a new AbstractAuthenticationHandler.setLoginResourceAttribute >> method which allows to set the "resource" request attribute as follows: >> >> * if the attribute is already set as a non-empty string, do nothing >> * If the "resource" request parameter is set as a non-empty string, use >> that >> * If a non-empty, non-null default value is given, use that >> * Otherwise fall back to the servlet context root path (or "/" if context >> root path is the empty string for the root context) >> >> Implemented in authentication Core, Form, OpenID, and Selector Form in Rev. >> 996477 >> >>> post-login redirect doesn't include context path >>> ------------------------------------------------ >>> >>> Key: SLING-1752 >>> URL: https://issues.apache.org/jira/browse/SLING-1752 >>> Project: Sling >>> Issue Type: Bug >>> Components: Authentication >>> Reporter: Justin Edelson >>> Assignee: Felix Meschberger >>> Fix For: Form Based Authentication 1.0.2, Auth Core 1.0.4 >>> >>> >>> to reproduce: >>> in launchpad/builder run >>> mvn -Djetty.sling.context=/sling clean jetty:run-war >>> then go to http://localhost:8888/sling/, try to log in, and then see that >>> you're redirected to "/", not "/sling/" >> > >
