On 30 Sep 2010, at 15:59, Justin Edelson wrote: >>> >>> >>> http://codereview.appspot.com/2333042 >> >> This looks like an elegant solution to me (ok, I am biased because it >> just reuses my own stuff ;-) ). >> >> +1
Thanks >> >> Regards >> Felix > > Made one nit-picky comment on the code, but otherwise +1. Would also > like to see an integration test :) Thank you, will do. > > That said, I'm still confused as to why Pax Web filter registration > isn't working for you, but I agree it would be appropriate to have > support for "container"-level filters like this. > > Justin I think it would work with the SlingMainServlet http context, but since that was registered first, at /*, any other http context or path does not appear to bind onto the SlingMainServlet. I suspect if I created a http context, registered a servlet at say /system/testing and then registered a filter on /system/* on the same http context the filter would bind to the servlet. Ian
