On Nov 30, 2010, at 2:52 AM, Bertrand Delacretaz wrote: > Hi Justin, > > On Tue, Nov 30, 2010 at 3:24 AM, Justin Edelson > <jus...@justinedelson.com> wrote: >> The problem with setting the compiler arguments in the archetype pom >> like this is that if the generated project is used inside of a >> multi-module project which sets the compiler source and target to 1.6, >> these values will overwrite those from the parent pom. > > Oh I see, didn't think of that. > > I think it's important than a naked project generated by the archetype > compiles out of the box...maybe we can leave those 1.5 settings and > add a comment that they should be removed if the pom is part of a > multi-module project?
How about this... we configure the compiler plugin with version = 2.3.2 (and no <configuration> block). As of version 2.3, 1.5 is the default for source and target. Best of both worlds? Justin > > -Bertrand > >> >> On Mon, Nov 29, 2010 at 3:32 AM, <bdelacre...@apache.org> wrote: >>> Author: bdelacretaz >>> Date: Mon Nov 29 08:32:59 2010 >>> New Revision: 1040034 >>> >>> URL: http://svn.apache.org/viewvc?rev=1040034&view=rev >>> Log: >>> generate pom needs source=1.5 to support annotations >>> >>> Modified: >>> >>> sling/trunk/maven/archetypes/servlet/src/main/resources/archetype-resources/pom.xml >>> >>> Modified: >>> sling/trunk/maven/archetypes/servlet/src/main/resources/archetype-resources/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/sling/trunk/maven/archetypes/servlet/src/main/resources/archetype-resources/pom.xml?rev=1040034&r1=1040033&r2=1040034&view=diff >>> ============================================================================== >>> --- >>> sling/trunk/maven/archetypes/servlet/src/main/resources/archetype-resources/pom.xml >>> (original) >>> +++ >>> sling/trunk/maven/archetypes/servlet/src/main/resources/archetype-resources/pom.xml >>> Mon Nov 29 08:32:59 2010 >>> @@ -46,6 +46,14 @@ >>> <extensions>true</extensions> >>> <version>2.0.1</version> >>> </plugin> >>> + <plugin> >>> + <groupId>org.apache.maven.plugins</groupId> >>> + <artifactId>maven-compiler-plugin</artifactId> >>> + <configuration> >>> + <source>1.5</source> >>> + <target>1.5</target> >>> + </configuration> >>> + </plugin> >>> </plugins> >>> </build> >>> <dependencies> >>> >>> >>> >>
