DominikSuess commented on a change in pull request #32:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/32#discussion_r520418736
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/handlers/XmlConfigurationEntryHandler.java
##########
@@ -65,13 +74,77 @@ protected void onJcrRootElement(String uri, String
localName, String qName, Attr
if (attributeValue != null && !attributeValue.isEmpty()) {
DocViewProperty property =
DocViewProperty.parse(attributeQName, attributeValue);
-
+ Object value = property.values;
+ List<String> strValues =
Arrays.asList(property.values);
+ switch (property.type) {
+ case PropertyType.DATE:
Review comment:
@bosschaert I only handle what the sling osgi installer supports and
handles - other types wouldn't work in sling:OsgiConfig nodes anyhow. The cnd
doesn't constrain it but the other properties woud be handled as String
representations in the osgi installer as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
