wimsymons commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#issuecomment-727926406
Hi, I reviewed your PR and made a few comments. But overall, you don't change the JCR query being executed, causing this to be slow for the initial load. You request *all* `sling:alias` in the repository (including those from `/jcr:system` and those from paths not on your allowed list) and than filter them out in code (inside the `isValidAliasPath` function). You should change the JCR query by adding something like ISDESCENDANTNODE for every path listed in the `resource.resolver.optimize.alias.allowedlist` OSGi property. This will filter them out *before* they are loaded. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
