[
https://issues.apache.org/jira/browse/SLING-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239251#comment-17239251
]
Bertrand Delacretaz edited comment on SLING-9930 at 11/26/20, 2:22 PM:
-----------------------------------------------------------------------
Not sure what you mean - yesterday I moved the tests from
[https://github.com/apache/sling-org-apache-sling-servlets-annotations-it] to
[https://github.com/apache/sling-org-apache-sling-servlets-annotations] , using
maven-invoker-plugin. Do you meant that those tests should be run from the main
pom of that module?
The [https://github.com/apache/sling-org-apache-sling-servlets-annotations-it]
is now deprecated but I see that you pushed changes to its SLING-9929 branch -
I think those changes should go under
[https://github.com/apache/sling-org-apache-sling-servlets-annotations/tree/master/src/it/annotations-it]
instead (I'm happy to merge them myself if you prefer)
was (Author: bdelacretaz):
Not sure what you mean - yesterday I moved the tests from
[https://github.com/apache/sling-org-apache-sling-servlets-annotations-it] to
[https://github.com/apache/sling-org-apache-sling-servlets-annotations] , using
maven-invoker-plugin. Do you meant that those tests should be run from the main
pom of that module?
The [https://github.com/apache/sling-org-apache-sling-servlets-annotations-it]
is now deprecated but I see that you pushed changes to its SLING-9929 branch -
I think those changes should go under
[https://github.com/apache/sling-org-apache-sling-servlets-annotations/tree/master/src/it/annotations-it]
instead.
> Move sling-servlets-annotations-it tests to sling-servlets-annotations module
> -----------------------------------------------------------------------------
>
> Key: SLING-9930
> URL: https://issues.apache.org/jira/browse/SLING-9930
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
> Affects Versions: Sling Servlet Annotations 1.2.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Sling Servlet Annotations 1.2.6
>
>
> Having the ITs in a different Git repository creates a slower feedback loop
> and makes the tests less visible.
> As recently done for
> [https://github.com/apache/sling-org-apache-sling-adapter-annotations], I'll
> move the integration tests to the sling-servlets-annotations module using
> maven-invoker-plugin.
> I'll use the [{{PaxExamServer}}-based
> tests|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/tree/SLING-9929]
> for that as they are stabler than the ones from the current {{master}}
> branch (where the Sling startup sometimes fail in testing).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
