[ 
https://issues.apache.org/jira/browse/SLING-9957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9957:
------------------------------------
    Fix Version/s: Content-Package to Feature Model Converter 1.0.24

> Hardcoded list of restriction names in RepPolicyEntryHandler.RepPolicyParser
> ----------------------------------------------------------------------------
>
>                 Key: SLING-9957
>                 URL: https://issues.apache.org/jira/browse/SLING-9957
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>            Reporter: Angela Schreiber
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.0.24
>
>
> the code at
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/RepPolicyEntryHandler.java#L121
> hardcodes the names of the supported restrictions. while those listed are the 
> restrictions currently supported by oak out of the box, oak allows for 
> customization (see 
> jackrabbit.apache.org/oak/docs/security/authorization/restriction.html) and 
> the set of supported restrictions may also evolve in oak.
> therefore the list should not be hardcoded. if obtaining the list of 
> supported restrictions from oak is not an option, it might be better to 
> assume that all child-properties of the protected {{rep:restrictions}} 
> (primary type {{rep:Restrictions}}) node below a given access control entry 
> are actually restrictions and treat them accordingly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to