jsedding commented on a change in pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#discussion_r535099785
##########
File path:
src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
##########
@@ -472,6 +466,19 @@ public boolean hasVanityPathPrecedence() {
return configs;
}
+ @Override
+
+ public CopyOnWriteArrayList<String> getAllowedAliasPaths() {
Review comment:
I suggest that sorting a list with 3 +/- 2 entries is acceptable in the
activate method. This "performance hit" is fully compensated by not needing to
sort the list repeatedly later on. Come on!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
