karlpauls commented on a change in pull request #40:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/40#discussion_r539452639
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/SystemUser.java
##########
@@ -25,10 +25,12 @@
private final String id;
private final RepoPath path;
+ private final RepoPath intermediatePath;
- public SystemUser(String id, RepoPath path) {
+ public SystemUser(String id, RepoPath path, RepoPath intermediatePath) {
Review comment:
Right, I think it is slightly nicer to have it be done outside the
constructor - just in case one wants to use a different path vs.
intermediatePath set-up where there is no direct parent relationship. However,
I totally agree it is overkill for the issue at hand and maybe it would be
better todo it inside the constructor. Let's keep it like this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
