[
https://issues.apache.org/jira/browse/SLING-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-9960.
-------------------------------
Resolution: Fixed
Done in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/42
Thanks [~Angela] for the review!
> AclManagerTest/RepPolicyEntryHandlerTest should use realistic service user
> path
> -------------------------------------------------------------------------------
>
> Key: SLING-9960
> URL: https://issues.apache.org/jira/browse/SLING-9960
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Reporter: Angela Schreiber
> Assignee: Karl Pauls
> Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> the code lines to add service users in {{AclManagerTest}} like
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/test/java/org/apache/sling/feature/cpconverter/acl/AclManagerTest.java#L74
> or
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/test/java/org/apache/sling/feature/cpconverter/acl/AclManagerTest.java#L79
> are a bit confusing to read. the path {{"/asd/public"}} would neither with a
> default jackrabbit/oak repository nor with Adobe AEM represent a valid path
> for a service user.... this makes it hard to understand the intention behind
> the code (see also SLING-9959 for why this matters).
> i would suggest to either use an absolute path starting with
> "/home/users/system" or the corresponding default path in Jackrabbit Oak
> concatenated with some arbitrary node name for the user node itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
