[ https://issues.apache.org/jira/browse/SLING-9999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263275#comment-17263275 ]
Radu Cotescu commented on SLING-9999: ------------------------------------- [~olli], I have nothing against reorganising the code if you feel that we could avoid some dependency chains. However, I would like to work on this a bit differently, in order to not hinder further development. Instead of commiting directly to `master`, do you think that we could: # revert all the changes you've done # create a branch on all affected modules # re-apply the changes you think are needed to this branch # open PRs and discuss them with the people interested in scripting I would like the {{master}} branches to be in a releasable state all the time. Right now I cannot start working on a fix for SLING-10012, since there are so many moving parts. > Remove cyclic dependency between scripting and servlets features > ---------------------------------------------------------------- > > Key: SLING-9999 > URL: https://issues.apache.org/jira/browse/SLING-9999 > Project: Sling > Issue Type: Improvement > Components: API, Karaf, Scripting, Servlets, Starter > Reporter: Oliver Lietz > Assignee: Oliver Lietz > Priority: Major > > Before {{org.apache.sling.scripting.core.impl.bundled}} and > {{org.apache.sling.servlets.resolver.bundle}} were added the dependency > chains were e.g. > {{sling-servlets}} → {{sling-scripting}} → {{sling}} > {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}} > Currently several _scripting_ modules depend on > {{org.apache.sling.servlets.resolver.bundle.tracker}}. > h2. Move _Bundle_ API to Scripting and Resource packages (modules) > ||Actual Package (Module)||Target Package (Module)|| > |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* > ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}* > ({{org.apache.sling.scripting.api}})| > |*{{org.apache.sling.servlets.resolver.bundle.tracker. > BundledRenderUnitCapability}}* > ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}* > ({{org.apache.sling.scripting.api}})| > |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}* > > ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}* > ({{org.apache.sling.scripting.api}})| > |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* > ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}* > ({{org.apache.sling.api}})| > |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* > ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}* > (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})| > ---- > ||Module||Commits||Status|| > |{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)| > |{{org.apache.sling.scripting.api}}|[d38759d|https://github.com/apache/sling-org-apache-sling-scripting-api/commit/d38759dbd3d4159f70ea54bff23b037be8d07cd6]|(/)| > |{{org.apache.sling.scripting.core}}|[b2f368a|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/b2f368a90a087979c34d8072fe529675971234fe], > > [1467cfa|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/1467cfa6a3fe4c77a628d078f9d944ce4cc42eb1]|(/)| > |{{org.apache.sling.scripting.jsp}}|[ccdb902|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/ccdb90266f254bb2143a5d870725a8f4b28d4d8b]|(/)| > |{{org.apache.sling.scripting.sightly}}|[1567894|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/1567894f6c1835a317c01e6c5b5987a260a74757], > > [b2f57cd|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/b2f57cd43d7d961fcf194cf7bf61b1c79f343d44]|(/)| > |{{org.apache.sling.servlets.resolver}}|[8262ce6|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]|(!) > probably more classes which should be living in a scripting module| -- This message was sent by Atlassian Jira (v8.3.4#803005)