paul-bjorkstrand commented on a change in pull request #10:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559228997



##########
File path: 
src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       This looks like it could be replaced with an implementation of 
[SortedMap] rather than a new, custom class. A benefit of using a SortedMap is 
that you can use either a concurrency safe version or not, depending on the use 
case.
   
   [SortedMap]: 
https://docs.oracle.com/javase/8/docs/api/java/util/SortedMap.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to