anchela opened a new pull request #56: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/56
@karlpauls , some intial work for SLING-10070. the following pieces are not yet completed, some marked with TODO: - parsing of *ServiceUserMapperImpl.*.cfg files returns a 'user.mapping' String and not a String array. i don't know if the problem is located with the test-files or if that is valid and needs extra parsing.... currently throws exception and is marked with TODO - Mapping (and thus the parsing) is copied from sling service-user-mapping... i would prefer to avoid the code duplication if possible - with the current flow in DefaultAclManager it will iterate multiple times over the mappings. - missing tests for those cases where principal-based ac setup cannot be enforced (single user mapping) - the would default to enforce if there was no mapping defined in the content package.... we might to verify that this is a reasonable assumption or log an error if there is no mapping defined. wdyt? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
