bdelacretaz commented on a change in pull request #17:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/17#discussion_r562644983
##########
File path:
src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java
##########
@@ -289,4 +332,71 @@ private String getDirectiveArgumentValue(Directive d,
String name) {
throw up;
}
}
+
+ GraphQLSchema getSchema(@NotNull String sdl, @NotNull Resource
currentResource, @NotNull String[] selectors) {
+ readLock.lock();
+ String newHash = SHA256Hasher.getHash(sdl);
+ String resourceToHashMapKey = getCacheKey(currentResource, selectors);
+ String oldHash = resourceToHashMap.get(resourceToHashMapKey);
Review comment:
might be good to add a comment about why you're using a composite cache
key, that was initially unclear to me. IIUC that's because buildWiring uses the
Resource and the services that it uses can changes outside of our control.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
