[
https://issues.apache.org/jira/browse/SLING-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10139:
----------------------------------------
Description:
The {{org.apache.sling.repoinit.parser.operations}} OSGi package version number
was increased to {{5.0.0}} in the affected release, but that's not really
justified as there were no actual semantic changes, and causes unnecessary
upgrade requirements.
We should fix that as described below, to avoid such issues going forward and
change that version number back to {{4.6.2}} which is what it should have been
after the changes released in version {{1.6.4}} of that module.
Here's the suggested changes as discussed with [~karlpauls]:
* Fix provider/consumer types in operations package, {{OperationVisitor}}
should be a {{ConsumerType}} (which is the default) and all other classes
{{ProviderType}}
* Downgrade operations package version number as mentioned above
* Move the {{helpers/WithPathOptions}} class to the {{impl}} package
* Add a comment in {{operations/package-info.java}} to skip version 5.0.0 and
jump to 6.0.0 next time an increase is needed, to avoid all confusion about
that {{5.0.0}} version
* Release the parser module with the baseline plugin disabled.
* Re-enable baseline plugin after the release
* Re-release the jcr-repoinit module so it has the correct import range (that
module has had changes anyway so that's fine)
was:
The {{org.apache.sling.repoinit.parser.operations}} OSGi package version number
was increased to {{5.0.0}} in the affected release, but that's not really
justified as there were no actual semantic changes, and causes unnecessary
upgrade requirements.
We should fix that as described below, to avoid such issues going forward and
change that version number back to {{4.6.2}} which is what it should have been
after the changes released in version {{1.6.4}} of that module.
Here's the suggested changes as discussed with [~karlpauls]:
* Fix provider/consumer types in operations package, {{OperationVisitor}}
should be a {{ConsumerType}} (which is the default) and all other classes
{{ProviderType}}
* Downgrade operations package version number as mentioned above
* Move the {{helpers/WithPathOptions}} class to the {{operations}} package
* Add a comment in {{operations/package-info.java}} to skip version 5.0.0 and
jump to 6.0.0 next time an increase is needed, to avoid all confusion about
that {{5.0.0}} version
* Release the parser module with the baseline plugin disabled.
* Re-enable baseline plugin after the release
* Re-release the jcr-repoinit module so it has the correct import range (that
module has had changes anyway so that's fine)
> Revert version change of o.a.s.repoinit.parser.operations and cleanup OSGi
> annotations
> --------------------------------------------------------------------------------------
>
> Key: SLING-10139
> URL: https://issues.apache.org/jira/browse/SLING-10139
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
> Affects Versions: Repoinit Parser 1.6.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
>
> The {{org.apache.sling.repoinit.parser.operations}} OSGi package version
> number was increased to {{5.0.0}} in the affected release, but that's not
> really justified as there were no actual semantic changes, and causes
> unnecessary upgrade requirements.
> We should fix that as described below, to avoid such issues going forward and
> change that version number back to {{4.6.2}} which is what it should have
> been after the changes released in version {{1.6.4}} of that module.
> Here's the suggested changes as discussed with [~karlpauls]:
> * Fix provider/consumer types in operations package, {{OperationVisitor}}
> should be a {{ConsumerType}} (which is the default) and all other classes
> {{ProviderType}}
> * Downgrade operations package version number as mentioned above
> * Move the {{helpers/WithPathOptions}} class to the {{impl}} package
> * Add a comment in {{operations/package-info.java}} to skip version 5.0.0 and
> jump to 6.0.0 next time an increase is needed, to avoid all confusion about
> that {{5.0.0}} version
> * Release the parser module with the baseline plugin disabled.
> * Re-enable baseline plugin after the release
> * Re-release the jcr-repoinit module so it has the correct import range (that
> module has had changes anyway so that's fine)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
