[
https://issues.apache.org/jira/browse/SLING-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-10172.
--------------------------------
Resolution: Fixed
Done in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/60
We know pick up the groupId and artifactId from the path if an embedded pom.xml
is found (and no pom.properties). Furthermore, use the BSN up to the last dot
as groupID and the rest as artifactID (and escape problematic characters in
both).
> Converter fails on artifacts with no GAV and bundle names with special
> characters
> ---------------------------------------------------------------------------------
>
> Key: SLING-10172
> URL: https://issues.apache.org/jira/browse/SLING-10172
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Affects Versions: Content-Package to Feature Model Converter 1.0.24
> Reporter: Karl Pauls
> Assignee: Karl Pauls
> Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> When the converter finds a bundle, it will first try to "read the GAV" from
> potentially embedded pom.properties. If it can't, it will fallback to the
> symbolic name as the groupID and the bundle name as the artifactID. That is
> problematic as the bundle name can contain special characters like e.g. {{:}}
> which are not allowed in an artifactID.
> Furthermore, if a bundle doesn't have pom.properties, it might still have the
> original pom.xml embedded (see [0] for an example).
> The converter should fallback to that embedded pom first before trying to use
> the bundle metadata. If that fails as well, it should likely use different
> parts of the metadata but regardless, properly escape whatever it uses.
> [0]
> https://repo1.maven.org/maven2/org/osgi/org.osgi.service.jdbc/1.0.0/org.osgi.service.jdbc-1.0.0.jar
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
