[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299356#comment-17299356 ]
Konrad Windszus commented on SLING-10205: ----------------------------------------- Before I come up with a PR a few other questions: Was there a reason to include only some package properties? Which ones are problematic to keep in the converted packages? The same for content below {{META-INF}}? If we should remove some properties/files we should rather go with a deny-list approach, than with an allow-list approach (like it is currently implemented). The flag for preserving as much as possible should by default be set to true because everything else is kind of unexpected from a user's PoV. > Support converting packages with custom properties and install hooks > -------------------------------------------------------------------- > > Key: SLING-10205 > URL: https://issues.apache.org/jira/browse/SLING-10205 > Project: Sling > Issue Type: Improvement > Components: Feature Model > Affects Versions: Content-Package to Feature Model Converter 1.0.24 > Reporter: Konrad Windszus > Priority: Major > > Currently only specific properties are being transferred to the converted > package: > https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/acf8c533590b9a081d64ca8e4787bed600f36386/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java#L93. > That e.g. prevents usage of [external install > hooks|http://jackrabbit.apache.org/filevault/installhooks.html] > Also no [internal install > hooks|http://jackrabbit.apache.org/filevault/installhooks.html] below > {{META-INF/vault/hooks}} are being copied to the converted package. -- This message was sent by Atlassian Jira (v8.3.4#803005)