kwin commented on a change in pull request #62:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/62#discussion_r595047040
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java
##########
@@ -248,14 +245,6 @@ public void addDependency(@NotNull Dependency dependency) {
IOUtils.copy(input, output);
}
- // copy the required resources
Review comment:
I can do that, but I am pretty sure the metadata should not be put below
`jcr_root`, but tracking separately is probably better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
