bdelacretaz commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596178215
##########
File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
##########
@@ -457,6 +465,13 @@ private void deactivate(final BundleContext bundleContext)
{
webConsolePlugin.unregister();
webConsolePlugin = null;
}
+
+ if (metricsService != null) {
Review comment:
Why not just `metricsService = null` ? Not sure why you'd need the test,
as no method is called on metricsService
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
